USB: serial: kl5kusb105: make logging less verbose
authorJohan Hovold <johan@kernel.org>
Tue, 10 Jan 2017 11:05:38 +0000 (12:05 +0100)
committerJohan Hovold <johan@kernel.org>
Mon, 16 Jan 2017 11:59:41 +0000 (12:59 +0100)
Replace a couple of dev_info with dev_dbg and remove another.

Also use the port device for logging, and include a radix prefix when
logging the baudrate.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/kl5kusb105.c

index 6cb4575..e6e083d 100644 (file)
@@ -143,10 +143,12 @@ static int klsi_105_chg_port_settings(struct usb_serial_port *port,
        if (rc < 0)
                dev_err(&port->dev,
                        "Change port settings failed (error = %d)\n", rc);
-       dev_info(&port->serial->dev->dev,
-                "%d byte block, baudrate %x, databits %d, u1 %d, u2 %d\n",
-                settings->pktlen, settings->baudrate, settings->databits,
-                settings->unknown1, settings->unknown2);
+
+       dev_dbg(&port->dev,
+               "pktlen %u, baudrate 0x%02x, databits %u, u1 %u, u2 %u\n",
+               settings->pktlen, settings->baudrate, settings->databits,
+               settings->unknown1, settings->unknown2);
+
        return rc;
 }
 
@@ -175,8 +177,6 @@ static int klsi_105_get_line_state(struct usb_serial_port *port,
        u8 *status_buf;
        __u16 status;
 
-       dev_info(&port->serial->dev->dev, "sending SIO Poll request\n");
-
        status_buf = kmalloc(KLSI_STATUSBUF_LEN, GFP_KERNEL);
        if (!status_buf)
                return -ENOMEM;
@@ -199,8 +199,8 @@ static int klsi_105_get_line_state(struct usb_serial_port *port,
        } else {
                status = get_unaligned_le16(status_buf);
 
-               dev_info(&port->serial->dev->dev, "read status %x %x\n",
-                        status_buf[0], status_buf[1]);
+               dev_dbg(&port->dev, "read status %02x %02x\n",
+                       status_buf[0], status_buf[1]);
 
                *line_state_p = klsi_105_status2linestate(status);
        }