KVM: SVM: fix error return code in svm_create_vcpu()
authorChen Zhou <chenzhou10@huawei.com>
Tue, 17 Nov 2020 02:54:26 +0000 (10:54 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 17 Nov 2020 07:40:08 +0000 (02:40 -0500)
Fix to return a negative error code from the error handling case
instead of 0 in function svm_create_vcpu(), as done elsewhere in this
function.

Fixes: f4c847a95654 ("KVM: SVM: refactor msr permission bitmap allocation")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Message-Id: <20201117025426.167824-1-chenzhou10@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/svm/svm.c

index 1e81cfe..79b3a56 100644 (file)
@@ -1309,8 +1309,10 @@ static int svm_create_vcpu(struct kvm_vcpu *vcpu)
                svm->avic_is_running = true;
 
        svm->msrpm = svm_vcpu_alloc_msrpm();
-       if (!svm->msrpm)
+       if (!svm->msrpm) {
+               err = -ENOMEM;
                goto error_free_vmcb_page;
+       }
 
        svm_vcpu_init_msrpm(vcpu, svm->msrpm);