tty: n_tty: remove unsigned char casts from character constants
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Sun, 27 Aug 2023 07:41:42 +0000 (09:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 27 Aug 2023 09:46:52 +0000 (11:46 +0200)
We compile with -funsigned-char, so all character constants are already
unsigned chars. Therefore, remove superfluous casts.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230827074147.2287-10-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_tty.c

index 632516d..369f5dd 100644 (file)
@@ -1347,7 +1347,7 @@ static bool n_tty_receive_char_canon(struct tty_struct *tty, u8 c)
                 * XXX does PARMRK doubling happen for
                 * EOL_CHAR and EOL2_CHAR?
                 */
-               if (c == (unsigned char) '\377' && I_PARMRK(tty))
+               if (c == '\377' && I_PARMRK(tty))
                        put_tty_queue(c, ldata);
 
                n_tty_receive_handle_newline(tty, c);
@@ -1409,7 +1409,7 @@ static void n_tty_receive_char_special(struct tty_struct *tty, unsigned char c,
        }
 
        /* PARMRK doubling check */
-       if (c == (unsigned char) '\377' && I_PARMRK(tty))
+       if (c == '\377' && I_PARMRK(tty))
                put_tty_queue(c, ldata);
 
        put_tty_queue(c, ldata);
@@ -1444,7 +1444,7 @@ static void n_tty_receive_char(struct tty_struct *tty, unsigned char c)
                commit_echoes(tty);
        }
        /* PARMRK doubling check */
-       if (c == (unsigned char) '\377' && I_PARMRK(tty))
+       if (c == '\377' && I_PARMRK(tty))
                put_tty_queue(c, ldata);
        put_tty_queue(c, ldata);
 }