macintosh/via-macii: Use the stack for reset request storage
authorFinn Thain <fthain@telegraphics.com.au>
Sun, 28 Jun 2020 04:23:12 +0000 (14:23 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 26 Jul 2020 13:34:25 +0000 (23:34 +1000)
The adb_request struct can be stored on the stack because the request
is synchronous and is completed before the function returns.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/a40f80dde90991757007b6962c386a208c970586.1593318192.git.fthain@telegraphics.com.au
drivers/macintosh/via-macii.c

index 4472739..2f9be4e 100644 (file)
@@ -313,7 +313,7 @@ static void macii_poll(void)
 /* Reset the bus */
 static int macii_reset_bus(void)
 {
-       static struct adb_request req;
+       struct adb_request req;
 
        /* Command = 0, Address = ignored */
        adb_request(&req, NULL, ADBREQ_NOSEND, 1, ADB_BUSRESET);