pinctrl: sprd: make three local functions static
authorColin Ian King <colin.king@canonical.com>
Mon, 4 Sep 2017 10:53:22 +0000 (11:53 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 12 Sep 2017 09:18:31 +0000 (11:18 +0200)
The functions sprd_pmx_get_function_count, sprd_pmx_get_function_name
and sprd_pmx_get_function_groups are local to the source and do not
need to be in global scope, so make them static.

Cleans up sparse warnings:
"symbol 'sprd_pmx_get_function_count' was not declared. Should it be
static?"
"symbol 'sprd_pmx_get_function_name' was not declared. Should it be
static?"
"symbol 'sprd_pmx_get_function_groups' was not declared. Should it be
static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sprd/pinctrl-sprd.c

index 7e7b9ac..c178b4a 100644 (file)
@@ -353,13 +353,13 @@ static const struct pinctrl_ops sprd_pctrl_ops = {
        .dt_free_map = pinctrl_utils_free_map,
 };
 
-int sprd_pmx_get_function_count(struct pinctrl_dev *pctldev)
+static int sprd_pmx_get_function_count(struct pinctrl_dev *pctldev)
 {
        return PIN_FUNC_MAX;
 }
 
-const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
-                                      unsigned int selector)
+static const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
+                                             unsigned int selector)
 {
        switch (selector) {
        case PIN_FUNC_1:
@@ -375,10 +375,10 @@ const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
        }
 }
 
-int sprd_pmx_get_function_groups(struct pinctrl_dev *pctldev,
-                                unsigned int selector,
-                                const char * const **groups,
-                                unsigned int * const num_groups)
+static int sprd_pmx_get_function_groups(struct pinctrl_dev *pctldev,
+                                       unsigned int selector,
+                                       const char * const **groups,
+                                       unsigned int * const num_groups)
 {
        struct sprd_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
        struct sprd_pinctrl_soc_info *info = pctl->info;