rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c
authorZheng Bin <zhengbin13@huawei.com>
Fri, 18 Sep 2020 10:24:59 +0000 (18:24 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 21 Sep 2020 13:02:43 +0000 (16:02 +0300)
Fixes coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:161:14-17: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:168:13-16: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:179:14-17: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:186:13-16: WARNING: Comparison to bool

Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200918102505.16036-4-zhengbin13@huawei.com
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c

index d7afb6a..2890a49 100644 (file)
@@ -158,14 +158,14 @@ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary)
 
        for (i = 0; i < (boundary - 1); i++) {
                rst = rtl92c_llt_write(hw, i , i + 1);
-               if (true != rst) {
+               if (!rst) {
                        pr_err("===> %s #1 fail\n", __func__);
                        return rst;
                }
        }
        /* end of list */
        rst = rtl92c_llt_write(hw, (boundary - 1), 0xFF);
-       if (true != rst) {
+       if (!rst) {
                pr_err("===> %s #2 fail\n", __func__);
                return rst;
        }
@@ -176,14 +176,14 @@ bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary)
         */
        for (i = boundary; i < LLT_LAST_ENTRY_OF_TX_PKT_BUFFER; i++) {
                rst = rtl92c_llt_write(hw, i, (i + 1));
-               if (true != rst) {
+               if (!rst) {
                        pr_err("===> %s #3 fail\n", __func__);
                        return rst;
                }
        }
        /* Let last entry point to the start entry of ring buffer */
        rst = rtl92c_llt_write(hw, LLT_LAST_ENTRY_OF_TX_PKT_BUFFER, boundary);
-       if (true != rst) {
+       if (!rst) {
                pr_err("===> %s #4 fail\n", __func__);
                return rst;
        }