staging: r8188eu: remove the bretry variable
authorMartin Kaiser <martin@kaiser.cx>
Sun, 3 Apr 2022 16:54:38 +0000 (18:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Apr 2022 14:32:43 +0000 (16:32 +0200)
Remove the bretry variable. It's set and used only once. Call the
ieee80211 helper directly.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220403165438.357728-12-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_recv.c

index e920978..91a6e0f 100644 (file)
@@ -936,7 +936,6 @@ static void validate_recv_mgnt_frame(struct adapter *padapter,
 static int validate_recv_data_frame(struct adapter *adapter,
                                    struct recv_frame *precv_frame)
 {
-       u8 bretry;
        struct sta_info *psta = NULL;
        u8 *ptr = precv_frame->rx_data;
        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)precv_frame->rx_data;
@@ -944,8 +943,6 @@ static int validate_recv_data_frame(struct adapter *adapter,
        struct security_priv    *psecuritypriv = &adapter->securitypriv;
        int ret;
 
-       bretry = ieee80211_has_retry(hdr->frame_control);
-
        memcpy(pattrib->dst, ieee80211_get_DA(hdr), ETH_ALEN);
        memcpy(pattrib->src, ieee80211_get_SA(hdr), ETH_ALEN);
 
@@ -999,7 +996,8 @@ static int validate_recv_data_frame(struct adapter *adapter,
        precv_frame->preorder_ctrl = &psta->recvreorder_ctrl[pattrib->priority];
 
        /*  decache, drop duplicate recv packets */
-       if (recv_decache(precv_frame, bretry, &psta->sta_recvpriv.rxcache) == _FAIL)
+       if (recv_decache(precv_frame, ieee80211_has_retry(hdr->frame_control),
+                        &psta->sta_recvpriv.rxcache) == _FAIL)
                return _FAIL;
 
        if (pattrib->privacy) {