net: hns3: Fix return of uninitialized variable ret
authorColin Ian King <colin.king@canonical.com>
Fri, 21 May 2021 10:01:46 +0000 (11:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 May 2021 20:56:18 +0000 (13:56 -0700)
In the unlikely event that rule_cnt is zero the variable ret is
not assigned a value and function hclge_dbg_dump_fd_tcam can end
up returning an unitialized value in ret. Fix this by explicitly
setting ret to zero before the for-loop.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: b5a0b70d77b9 ("net: hns3: refactor dump fd tcam of debugfs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c

index dd9eb6e..0b7c683 100644 (file)
@@ -1519,6 +1519,7 @@ static int hclge_dbg_dump_fd_tcam(struct hclge_dev *hdev, char *buf, int len)
                goto out;
        }
 
+       ret = 0;
        for (i = 0; i < rule_cnt; i++) {
                tcam_msg.stage = HCLGE_FD_STAGE_1;
                tcam_msg.loc = rule_locs[i];