projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dc0ba74
)
backlight: da9052: Fully initialize backlight_properties during probe
author
Daniel Thompson
<daniel.thompson@linaro.org>
Tue, 20 Feb 2024 15:35:24 +0000
(15:35 +0000)
committer
Lee Jones
<lee@kernel.org>
Thu, 7 Mar 2024 09:03:29 +0000
(09:03 +0000)
props is stack allocated and the fields that are not explcitly set
by the probe function need to be zeroed or we'll get undefined behaviour
(especially so power/blank states)!
Fixes:
6ede3d832aaa
("backlight: add driver for DA9052/53 PMIC v1")
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Link:
https://lore.kernel.org/r/20240220153532.76613-2-daniel.thompson@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/da9052_bl.c
patch
|
blob
|
history
diff --git
a/drivers/video/backlight/da9052_bl.c
b/drivers/video/backlight/da9052_bl.c
index
1cdc854
..
b8ff704
100644
(file)
--- a/
drivers/video/backlight/da9052_bl.c
+++ b/
drivers/video/backlight/da9052_bl.c
@@
-117,6
+117,7
@@
static int da9052_backlight_probe(struct platform_device *pdev)
wleds->led_reg = platform_get_device_id(pdev)->driver_data;
wleds->state = DA9052_WLEDS_OFF;
+ memset(&props, 0, sizeof(struct backlight_properties));
props.type = BACKLIGHT_RAW;
props.max_brightness = DA9052_MAX_BRIGHTNESS;