clk: renesas: r9a06g032: Repair grave increment error
authorMarek Vasut <marex@denx.de>
Fri, 28 Oct 2022 11:38:34 +0000 (13:38 +0200)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 1 Nov 2022 09:15:28 +0000 (10:15 +0100)
If condition (clkspec.np != pd->dev.of_node) is true, then the driver
ends up in an endless loop, forever, locking up the machine.

Fixes: aad03a66f902 ("clk: renesas: r9a06g032: Add clock domain support")
Reviewed-by: Ralph Siemsen <ralph.siemsen@linaro.org>
Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Gareth Williams <gareth.williams.jx@renesas.com>
Link: https://lore.kernel.org/r/20221028113834.7496-1-marex@denx.de
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/clk/renesas/r9a06g032-clocks.c

index 1488c9d..983faa5 100644 (file)
@@ -412,7 +412,7 @@ static int r9a06g032_attach_dev(struct generic_pm_domain *pd,
        int error;
        int index;
 
-       while (!of_parse_phandle_with_args(np, "clocks", "#clock-cells", i,
+       while (!of_parse_phandle_with_args(np, "clocks", "#clock-cells", i++,
                                           &clkspec)) {
                if (clkspec.np != pd->dev.of_node)
                        continue;
@@ -425,7 +425,6 @@ static int r9a06g032_attach_dev(struct generic_pm_domain *pd,
                        if (error)
                                return error;
                }
-               i++;
        }
 
        return 0;