Make the frequency set/get functionality common to all ASICs.
This makes more code reusable when adding support for newer ASICs.
Signed-off-by: Rajaravi Krishna Katta <rkatta@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
                common/command_buffer.o common/hw_queue.o common/irq.o \
                common/sysfs.o common/hwmon.o common/memory.o \
                common/command_submission.o common/firmware_if.o \
-               common/state_dump.o
+               common/state_dump.o common/hwmgr.o
 
  *                  for hints validity check.
  * device_dma_offset_for_host_access: the offset to add to host DMA addresses
  *                                    to enable the device to access them.
+ * @max_freq_value: current max clk frequency.
+ * @clk_pll_index: clock PLL index that specify which PLL determines the clock
+ *                 we display to the user
  * @mmu_pgt_size: MMU page tables total size.
  * @mmu_pte_size: PTE size in MMU page tables.
  * @mmu_hop_table_size: MMU hop table size.
        u64                             cb_va_end_addr;
        u64                             dram_hints_align_mask;
        u64                             device_dma_offset_for_host_access;
+       u64                             max_freq_value;
+       u32                             clk_pll_index;
        u32                             mmu_pgt_size;
        u32                             mmu_pte_size;
        u32                             mmu_hop_table_size;
                        int sensor_index, u32 attr, long value);
 int hl_get_power(struct hl_device *hdev,
                        int sensor_index, u32 attr, long *value);
+int hl_get_clk_rate(struct hl_device *hdev,
+                       u32 *cur_clk, u32 *max_clk);
+void hl_set_pll_profile(struct hl_device *hdev, enum hl_pll_frequency freq);
+void hl_add_device_attr(struct hl_device *hdev,
+                       struct attribute_group *dev_attr_grp);
 void hw_sob_get(struct hl_hw_sob *hw_sob);
 void hw_sob_put(struct hl_hw_sob *hw_sob);
 void hl_encaps_handle_do_release(struct kref *ref);
 
--- /dev/null
+// SPDX-License-Identifier: GPL-2.0
+
+/*
+ * Copyright 2019-2021 HabanaLabs, Ltd.
+ * All Rights Reserved.
+ */
+
+#include "habanalabs.h"
+
+void hl_set_pll_profile(struct hl_device *hdev, enum hl_pll_frequency freq)
+{
+       hl_set_frequency(hdev, hdev->asic_prop.clk_pll_index,
+                       hdev->asic_prop.max_freq_value);
+}
+
+int hl_get_clk_rate(struct hl_device *hdev, u32 *cur_clk, u32 *max_clk)
+{
+       long value;
+
+       if (!hl_device_operational(hdev, NULL))
+               return -ENODEV;
+
+       value = hl_get_frequency(hdev, hdev->asic_prop.clk_pll_index, false);
+
+       if (value < 0) {
+               dev_err(hdev->dev, "Failed to retrieve device max clock %ld\n",
+                       value);
+               return value;
+       }
+
+       *max_clk = (value / 1000 / 1000);
+
+       value = hl_get_frequency(hdev, hdev->asic_prop.clk_pll_index, true);
+
+       if (value < 0) {
+               dev_err(hdev->dev,
+                       "Failed to retrieve device current clock %ld\n",
+                       value);
+               return value;
+       }
+
+       *cur_clk = (value / 1000 / 1000);
+
+       return 0;
+}
+
+static ssize_t clk_max_freq_mhz_show(struct device *dev,
+               struct device_attribute *attr, char *buf)
+{
+       struct hl_device *hdev = dev_get_drvdata(dev);
+       long value;
+
+       if (!hl_device_operational(hdev, NULL))
+               return -ENODEV;
+
+       value = hl_get_frequency(hdev, hdev->asic_prop.clk_pll_index, false);
+
+       hdev->asic_prop.max_freq_value = value;
+
+       return sprintf(buf, "%lu\n", (value / 1000 / 1000));
+}
+
+static ssize_t clk_max_freq_mhz_store(struct device *dev,
+               struct device_attribute *attr, const char *buf, size_t count)
+{
+       struct hl_device *hdev = dev_get_drvdata(dev);
+       int rc;
+       u64 value;
+
+       if (!hl_device_operational(hdev, NULL)) {
+               count = -ENODEV;
+               goto fail;
+       }
+
+       rc = kstrtoull(buf, 0, &value);
+       if (rc) {
+               count = -EINVAL;
+               goto fail;
+       }
+
+       hdev->asic_prop.max_freq_value = value * 1000 * 1000;
+
+       hl_set_frequency(hdev, hdev->asic_prop.clk_pll_index,
+                       hdev->asic_prop.max_freq_value);
+
+fail:
+       return count;
+}
+
+static ssize_t clk_cur_freq_mhz_show(struct device *dev,
+               struct device_attribute *attr, char *buf)
+{
+       struct hl_device *hdev = dev_get_drvdata(dev);
+       long value;
+
+       if (!hl_device_operational(hdev, NULL))
+               return -ENODEV;
+
+       value = hl_get_frequency(hdev, hdev->asic_prop.clk_pll_index, true);
+
+       return sprintf(buf, "%lu\n", (value / 1000 / 1000));
+}
+
+static DEVICE_ATTR_RW(clk_max_freq_mhz);
+static DEVICE_ATTR_RO(clk_cur_freq_mhz);
+
+static struct attribute *hl_dev_attrs[] = {
+       &dev_attr_clk_max_freq_mhz.attr,
+       &dev_attr_clk_cur_freq_mhz.attr,
+       NULL,
+};
+
+void hl_add_device_attr(struct hl_device *hdev,
+                       struct attribute_group *dev_attr_grp)
+{
+       dev_attr_grp->attrs = hl_dev_attrs;
+}
 
 # SPDX-License-Identifier: GPL-2.0-only
-HL_GAUDI_FILES := gaudi/gaudi.o gaudi/gaudi_hwmgr.o gaudi/gaudi_security.o \
+HL_GAUDI_FILES := gaudi/gaudi.o gaudi/gaudi_security.o \
        gaudi/gaudi_coresight.o
 
 
        prop->server_type = HL_SERVER_TYPE_UNKNOWN;
 
+       prop->clk_pll_index = HL_GAUDI_MME_PLL;
+       prop->max_freq_value = GAUDI_MAX_CLK_FREQ;
+
        return 0;
 }
 
 
        gaudi->cpucp_info_get = gaudi_cpucp_info_get;
 
-       gaudi->max_freq_value = GAUDI_MAX_CLK_FREQ;
-
        hdev->asic_specific = gaudi;
 
        /* Create DMA pool for small allocations */
        .debugfs_read64 = gaudi_debugfs_read64,
        .debugfs_write64 = gaudi_debugfs_write64,
        .debugfs_read_dma = gaudi_debugfs_read_dma,
-       .add_device_attr = gaudi_add_device_attr,
+       .add_device_attr = hl_add_device_attr,
        .handle_eqe = gaudi_handle_eqe,
-       .set_pll_profile = gaudi_set_pll_profile,
+       .set_pll_profile = hl_set_pll_profile,
        .get_events_stat = gaudi_get_events_stat,
        .read_pte = gaudi_read_pte,
        .write_pte = gaudi_write_pte,
        .halt_coresight = gaudi_halt_coresight,
        .ctx_init = gaudi_ctx_init,
        .ctx_fini = gaudi_ctx_fini,
-       .get_clk_rate = gaudi_get_clk_rate,
+       .get_clk_rate = hl_get_clk_rate,
        .get_queue_id_for_cq = gaudi_get_queue_id_for_cq,
        .load_firmware_to_device = gaudi_load_firmware_to_device,
        .load_boot_fit_to_device = gaudi_load_boot_fit_to_device,
 
  *                  the actual number of internal queues because they are not in
  *                  consecutive order.
  * @hbm_bar_cur_addr: current address of HBM PCI bar.
- * @max_freq_value: current max clk frequency.
  * @events: array that holds all event id's
  * @events_stat: array that holds histogram of all received events.
  * @events_stat_aggregate: same as events_stat but doesn't get cleared on reset
        struct gaudi_collective_properties collective_props;
 
        u64                             hbm_bar_cur_addr;
-       u64                             max_freq_value;
 
        u32                             events[GAUDI_EVENT_SIZE];
        u32                             events_stat[GAUDI_EVENT_SIZE];
 void gaudi_ack_protection_bits_errors(struct hl_device *hdev);
 void gaudi_add_device_attr(struct hl_device *hdev,
                        struct attribute_group *dev_attr_grp);
-void gaudi_set_pll_profile(struct hl_device *hdev, enum hl_pll_frequency freq);
 int gaudi_debug_coresight(struct hl_device *hdev, void *data);
 void gaudi_halt_coresight(struct hl_device *hdev);
-int gaudi_get_clk_rate(struct hl_device *hdev, u32 *cur_clk, u32 *max_clk);
 void gaudi_mmu_prepare_reg(struct hl_device *hdev, u64 reg, u32 asid);
 
 #endif /* GAUDIP_H_ */
 
+++ /dev/null
-// SPDX-License-Identifier: GPL-2.0
-
-/*
- * Copyright 2016-2018 HabanaLabs, Ltd.
- * All Rights Reserved.
- */
-
-#include "gaudiP.h"
-#include "../include/gaudi/gaudi_fw_if.h"
-
-void gaudi_set_pll_profile(struct hl_device *hdev, enum hl_pll_frequency freq)
-{
-       struct gaudi_device *gaudi = hdev->asic_specific;
-
-       if (freq == PLL_LAST)
-               hl_set_frequency(hdev, HL_GAUDI_MME_PLL, gaudi->max_freq_value);
-}
-
-int gaudi_get_clk_rate(struct hl_device *hdev, u32 *cur_clk, u32 *max_clk)
-{
-       long value;
-
-       if (!hl_device_operational(hdev, NULL))
-               return -ENODEV;
-
-       value = hl_get_frequency(hdev, HL_GAUDI_MME_PLL, false);
-
-       if (value < 0) {
-               dev_err(hdev->dev, "Failed to retrieve device max clock %ld\n",
-                       value);
-               return value;
-       }
-
-       *max_clk = (value / 1000 / 1000);
-
-       value = hl_get_frequency(hdev, HL_GAUDI_MME_PLL, true);
-
-       if (value < 0) {
-               dev_err(hdev->dev,
-                       "Failed to retrieve device current clock %ld\n",
-                       value);
-               return value;
-       }
-
-       *cur_clk = (value / 1000 / 1000);
-
-       return 0;
-}
-
-static ssize_t clk_max_freq_mhz_show(struct device *dev,
-               struct device_attribute *attr, char *buf)
-{
-       struct hl_device *hdev = dev_get_drvdata(dev);
-       struct gaudi_device *gaudi = hdev->asic_specific;
-       long value;
-
-       if (!hl_device_operational(hdev, NULL))
-               return -ENODEV;
-
-       value = hl_get_frequency(hdev, HL_GAUDI_MME_PLL, false);
-
-       gaudi->max_freq_value = value;
-
-       return sprintf(buf, "%lu\n", (value / 1000 / 1000));
-}
-
-static ssize_t clk_max_freq_mhz_store(struct device *dev,
-               struct device_attribute *attr, const char *buf, size_t count)
-{
-       struct hl_device *hdev = dev_get_drvdata(dev);
-       struct gaudi_device *gaudi = hdev->asic_specific;
-       int rc;
-       u64 value;
-
-       if (!hl_device_operational(hdev, NULL)) {
-               count = -ENODEV;
-               goto fail;
-       }
-
-       rc = kstrtoull(buf, 0, &value);
-       if (rc) {
-               count = -EINVAL;
-               goto fail;
-       }
-
-       gaudi->max_freq_value = value * 1000 * 1000;
-
-       hl_set_frequency(hdev, HL_GAUDI_MME_PLL, gaudi->max_freq_value);
-
-fail:
-       return count;
-}
-
-static ssize_t clk_cur_freq_mhz_show(struct device *dev,
-               struct device_attribute *attr, char *buf)
-{
-       struct hl_device *hdev = dev_get_drvdata(dev);
-       long value;
-
-       if (!hl_device_operational(hdev, NULL))
-               return -ENODEV;
-
-       value = hl_get_frequency(hdev, HL_GAUDI_MME_PLL, true);
-
-       return sprintf(buf, "%lu\n", (value / 1000 / 1000));
-}
-
-static DEVICE_ATTR_RW(clk_max_freq_mhz);
-static DEVICE_ATTR_RO(clk_cur_freq_mhz);
-
-static struct attribute *gaudi_dev_attrs[] = {
-       &dev_attr_clk_max_freq_mhz.attr,
-       &dev_attr_clk_cur_freq_mhz.attr,
-       NULL,
-};
-
-void gaudi_add_device_attr(struct hl_device *hdev,
-                       struct attribute_group *dev_attr_grp)
-{
-       dev_attr_grp->attrs = gaudi_dev_attrs;
-}
 
 
        prop->server_type = HL_SERVER_TYPE_UNKNOWN;
 
+       prop->clk_pll_index = HL_GOYA_MME_PLL;
+
        return 0;
 }
 
        .halt_coresight = goya_halt_coresight,
        .ctx_init = goya_ctx_init,
        .ctx_fini = goya_ctx_fini,
-       .get_clk_rate = goya_get_clk_rate,
+       .get_clk_rate = hl_get_clk_rate,
        .get_queue_id_for_cq = goya_get_queue_id_for_cq,
        .load_firmware_to_device = goya_load_firmware_to_device,
        .load_boot_fit_to_device = goya_load_boot_fit_to_device,
 
                                        void *vaddr);
 void goya_mmu_remove_device_cpu_mappings(struct hl_device *hdev);
 
-int goya_get_clk_rate(struct hl_device *hdev, u32 *cur_clk, u32 *max_clk);
 u32 goya_get_queue_id_for_cq(struct hl_device *hdev, u32 cq_idx);
 u64 goya_get_device_time(struct hl_device *hdev);
 
 
        }
 }
 
-int goya_get_clk_rate(struct hl_device *hdev, u32 *cur_clk, u32 *max_clk)
-{
-       long value;
-
-       if (!hl_device_operational(hdev, NULL))
-               return -ENODEV;
-
-       value = hl_get_frequency(hdev, HL_GOYA_MME_PLL, false);
-
-       if (value < 0) {
-               dev_err(hdev->dev, "Failed to retrieve device max clock %ld\n",
-                       value);
-               return value;
-       }
-
-       *max_clk = (value / 1000 / 1000);
-
-       value = hl_get_frequency(hdev, HL_GOYA_MME_PLL, true);
-
-       if (value < 0) {
-               dev_err(hdev->dev,
-                       "Failed to retrieve device current clock %ld\n",
-                       value);
-               return value;
-       }
-
-       *cur_clk = (value / 1000 / 1000);
-
-       return 0;
-}
-
 static ssize_t mme_clk_show(struct device *dev, struct device_attribute *attr,
                                char *buf)
 {