PM / devfreq: imx: Register interconnect device
authorLeonard Crestez <leonard.crestez@nxp.com>
Mon, 6 Apr 2020 12:03:08 +0000 (15:03 +0300)
committerChanwoo Choi <cw00.choi@samsung.com>
Thu, 28 May 2020 09:02:39 +0000 (18:02 +0900)
There is no single device which can represent the imx interconnect.
Instead of adding a virtual one just make the main &noc act as the
global interconnect provider.

The imx interconnect provider driver will scale the NOC and DDRC based
on bandwidth request. More scalable nodes can be added in the future,
for example for audio/display/vpu/gpu NICs.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/devfreq/imx-bus.c

index 428f798..532e795 100644 (file)
@@ -16,6 +16,7 @@ struct imx_bus {
        struct devfreq_dev_profile profile;
        struct devfreq *devfreq;
        struct clk *clk;
+       struct platform_device *icc_pdev;
 };
 
 static int imx_bus_target(struct device *dev,
@@ -58,7 +59,40 @@ static int imx_bus_get_dev_status(struct device *dev,
 
 static void imx_bus_exit(struct device *dev)
 {
+       struct imx_bus *priv = dev_get_drvdata(dev);
+
        dev_pm_opp_of_remove_table(dev);
+       platform_device_unregister(priv->icc_pdev);
+}
+
+/* imx_bus_init_icc() - register matching icc provider if required */
+static int imx_bus_init_icc(struct device *dev)
+{
+       struct imx_bus *priv = dev_get_drvdata(dev);
+       const char *icc_driver_name;
+
+       if (!of_get_property(dev->of_node, "#interconnect-cells", 0))
+               return 0;
+       if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) {
+               dev_warn(dev, "imx interconnect drivers disabled\n");
+               return 0;
+       }
+
+       icc_driver_name = of_device_get_match_data(dev);
+       if (!icc_driver_name) {
+               dev_err(dev, "unknown interconnect driver\n");
+               return 0;
+       }
+
+       priv->icc_pdev = platform_device_register_data(
+                       dev, icc_driver_name, -1, NULL, 0);
+       if (IS_ERR(priv->icc_pdev)) {
+               dev_err(dev, "failed to register icc provider %s: %ld\n",
+                               icc_driver_name, PTR_ERR(priv->devfreq));
+               return PTR_ERR(priv->devfreq);
+       }
+
+       return 0;
 }
 
 static int imx_bus_probe(struct platform_device *pdev)
@@ -110,6 +144,10 @@ static int imx_bus_probe(struct platform_device *pdev)
                goto err;
        }
 
+       ret = imx_bus_init_icc(dev);
+       if (ret)
+               goto err;
+
        return 0;
 
 err:
@@ -118,6 +156,9 @@ err:
 }
 
 static const struct of_device_id imx_bus_of_match[] = {
+       { .compatible = "fsl,imx8mq-noc", .data = "imx8mq-interconnect", },
+       { .compatible = "fsl,imx8mm-noc", .data = "imx8mm-interconnect", },
+       { .compatible = "fsl,imx8mn-noc", .data = "imx8mn-interconnect", },
        { .compatible = "fsl,imx8m-noc", },
        { .compatible = "fsl,imx8m-nic", },
        { /* sentinel */ },