can: Use netif_rx().
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Sat, 5 Mar 2022 22:12:46 +0000 (23:12 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 6 Mar 2022 11:05:31 +0000 (11:05 +0000)
Since commit
   baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.")

the function netif_rx() can be used in preemptible/thread context as
well as in interrupt context.

Use netif_rx().

Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/dev/dev.c
drivers/net/can/slcan.c
drivers/net/can/spi/hi311x.c
drivers/net/can/spi/mcp251x.c
drivers/net/can/vcan.c
drivers/net/can/vxcan.c
net/can/af_can.c

index c192f25..e7ab45f 100644 (file)
@@ -154,7 +154,7 @@ static void can_restart(struct net_device *dev)
 
        cf->can_id |= CAN_ERR_RESTARTED;
 
-       netif_rx_ni(skb);
+       netif_rx(skb);
 
 restart:
        netdev_dbg(dev, "restarted\n");
index 27783fb..ec294d0 100644 (file)
@@ -221,7 +221,7 @@ static void slc_bump(struct slcan *sl)
        if (!(cf.can_id & CAN_RTR_FLAG))
                sl->dev->stats.rx_bytes += cf.len;
 
-       netif_rx_ni(skb);
+       netif_rx(skb);
 }
 
 /* parse tty input stream */
index 664b8f1..a5b2952 100644 (file)
@@ -356,7 +356,7 @@ static void hi3110_hw_rx(struct spi_device *spi)
 
        can_led_event(priv->net, CAN_LED_EVENT_RX);
 
-       netif_rx_ni(skb);
+       netif_rx(skb);
 }
 
 static void hi3110_hw_sleep(struct spi_device *spi)
@@ -677,7 +677,7 @@ static irqreturn_t hi3110_can_ist(int irq, void *dev_id)
                        tx_state = txerr >= rxerr ? new_state : 0;
                        rx_state = txerr <= rxerr ? new_state : 0;
                        can_change_state(net, cf, tx_state, rx_state);
-                       netif_rx_ni(skb);
+                       netif_rx(skb);
 
                        if (new_state == CAN_STATE_BUS_OFF) {
                                can_bus_off(net);
@@ -718,7 +718,7 @@ static irqreturn_t hi3110_can_ist(int irq, void *dev_id)
                                cf->data[6] = hi3110_read(spi, HI3110_READ_TEC);
                                cf->data[7] = hi3110_read(spi, HI3110_READ_REC);
                                netdev_dbg(priv->net, "Bus Error\n");
-                               netif_rx_ni(skb);
+                               netif_rx(skb);
                        }
                }
 
index d23edaf..fc747bf 100644 (file)
@@ -740,7 +740,7 @@ static void mcp251x_hw_rx(struct spi_device *spi, int buf_idx)
 
        can_led_event(priv->net, CAN_LED_EVENT_RX);
 
-       netif_rx_ni(skb);
+       netif_rx(skb);
 }
 
 static void mcp251x_hw_sleep(struct spi_device *spi)
@@ -987,7 +987,7 @@ static void mcp251x_error_skb(struct net_device *net, int can_id, int data1)
        if (skb) {
                frame->can_id |= can_id;
                frame->data[1] = data1;
-               netif_rx_ni(skb);
+               netif_rx(skb);
        } else {
                netdev_err(net, "cannot allocate error skb\n");
        }
index c42f188..a15619d 100644 (file)
@@ -80,7 +80,7 @@ static void vcan_rx(struct sk_buff *skb, struct net_device *dev)
        skb->dev       = dev;
        skb->ip_summed = CHECKSUM_UNNECESSARY;
 
-       netif_rx_ni(skb);
+       netif_rx(skb);
 }
 
 static netdev_tx_t vcan_tx(struct sk_buff *skb, struct net_device *dev)
index 47ccc15..556f1a1 100644 (file)
@@ -63,7 +63,7 @@ static netdev_tx_t vxcan_xmit(struct sk_buff *skb, struct net_device *dev)
        skb->ip_summed  = CHECKSUM_UNNECESSARY;
 
        len = cfd->can_id & CAN_RTR_FLAG ? 0 : cfd->len;
-       if (netif_rx_ni(skb) == NET_RX_SUCCESS) {
+       if (netif_rx(skb) == NET_RX_SUCCESS) {
                srcstats->tx_packets++;
                srcstats->tx_bytes += len;
                peerstats = &peer->stats;
index cce2af1..1fb49d5 100644 (file)
@@ -284,7 +284,7 @@ int can_send(struct sk_buff *skb, int loop)
        }
 
        if (newskb)
-               netif_rx_ni(newskb);
+               netif_rx(newskb);
 
        /* update statistics */
        pkg_stats->tx_frames++;