pwm: bcm-iproc: Free resources only after pwmchip_remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 24 Mar 2021 20:01:34 +0000 (21:01 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Fri, 9 Apr 2021 12:33:10 +0000 (14:33 +0200)
Before pwmchip_remove() returns the PWM is expected to be functional. So
remove the pwmchip before disabling the clock.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-bcm-iproc.c

index 529a66a..edd2ce1 100644 (file)
@@ -253,9 +253,11 @@ static int iproc_pwmc_remove(struct platform_device *pdev)
 {
        struct iproc_pwmc *ip = platform_get_drvdata(pdev);
 
 {
        struct iproc_pwmc *ip = platform_get_drvdata(pdev);
 
+       pwmchip_remove(&ip->chip);
+
        clk_disable_unprepare(ip->clk);
 
        clk_disable_unprepare(ip->clk);
 
-       return pwmchip_remove(&ip->chip);
+       return 0;
 }
 
 static const struct of_device_id bcm_iproc_pwmc_dt[] = {
 }
 
 static const struct of_device_id bcm_iproc_pwmc_dt[] = {