aio: remove an outdated BUG_ON and comment in aio_complete
authorChristoph Hellwig <hch@lst.de>
Thu, 23 Nov 2017 18:53:40 +0000 (19:53 +0100)
committerChristoph Hellwig <hch@lst.de>
Wed, 2 May 2018 17:52:38 +0000 (19:52 +0200)
These days we don't treat sync iocbs special in the aio completion code as
they never use it.  Remove the old comment and BUG_ON given that the
current definition of is_sync_kiocb makes it impossible to hit.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/aio.c

index add46b0..7c1855a 100644 (file)
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1107,15 +1107,6 @@ static void aio_complete(struct kiocb *kiocb, long res, long res2)
                file_end_write(file);
        }
 
                file_end_write(file);
        }
 
-       /*
-        * Special case handling for sync iocbs:
-        *  - events go directly into the iocb for fast handling
-        *  - the sync task with the iocb in its stack holds the single iocb
-        *    ref, no other paths have a way to get another ref
-        *  - the sync task helpfully left a reference to itself in the iocb
-        */
-       BUG_ON(is_sync_kiocb(kiocb));
-
        if (iocb->ki_list.next) {
                unsigned long flags;
 
        if (iocb->ki_list.next) {
                unsigned long flags;