Use snprintf() to avoid the potential buffer overflow, and also
check the return value to detect the too long path.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
for (mod = modules; mod; mod = mod->next) {
char fname[PATH_MAX];
for (mod = modules; mod; mod = mod->next) {
char fname[PATH_MAX];
if (mod->is_vmlinux || mod->from_dump)
continue;
if (mod->is_vmlinux || mod->from_dump)
continue;
add_moddevtable(&buf, mod);
add_srcversion(&buf, mod);
add_moddevtable(&buf, mod);
add_srcversion(&buf, mod);
- sprintf(fname, "%s.mod.c", mod->name);
+ ret = snprintf(fname, sizeof(fname), "%s.mod.c", mod->name);
+ if (ret >= sizeof(fname)) {
+ error("%s: too long path was truncated\n", fname);
+ continue;
+ }
+
write_if_changed(&buf, fname);
}
write_if_changed(&buf, fname);
}