thermal/drivers/cpufreq_cooling: Fix return of cpufreq_set_cur_state
authorWilly Wolff <willy.mh.wolff.ml@gmail.com>
Sat, 21 Mar 2020 09:27:40 +0000 (09:27 +0000)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 23 Mar 2020 14:20:47 +0000 (15:20 +0100)
commitff44f672d74178b3be19d41a169b98b3e391d4ce
tree656875c793f382a9e7b70b65379203974b6acd57
parent2b8f1f0337c55fb26347dda90112dfd8fe326ec5
thermal/drivers/cpufreq_cooling: Fix return of cpufreq_set_cur_state

When setting the cooling device current state from userspace via sysfs,
the operation fails by returning an -EINVAL.

It appears the recent changes with the per-policy frequency QoS
introduced a regression as reported by:

 https://lkml.org/lkml/2020/3/20/599

The function freq_qos_update_request returns 0 or 1 describing update
effectiveness, and a negative error code on failure. However,
cpufreq_set_cur_state returns 0 on success or an error code otherwise.

Consider the QoS update as successful if the function does not return
an error.

Fixes: 3000ce3c52f8b ("cpufreq: Use per-policy frequency QoS")
Signed-off-by: Willy Wolff <willy.mh.wolff.ml@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20200321092740.7vvwfxsebcrznydh@macmini.local
drivers/thermal/cpufreq_cooling.c