ntfs: Use ERR_CAST() to avoid cross-structure cast
authorKees Cook <keescook@chromium.org>
Mon, 8 May 2017 21:45:26 +0000 (14:45 -0700)
committerKees Cook <keescook@chromium.org>
Sun, 28 May 2017 17:11:48 +0000 (10:11 -0700)
commitfee2aa753823860f2b8dfe58d98cafe8e4840855
treeaff1b1fa62bc05b1d7f0f298ffb1ec8e10742e69
parentfe3b81b446d4ecb954f1b9dd191164a78fd278ad
ntfs: Use ERR_CAST() to avoid cross-structure cast

When trying to propagate an error result, the error return path attempts
to retain the error, but does this with an open cast across very different
types, which the upcoming structure layout randomization plugin flags as
being potentially dangerous in the face of randomization. This is a false
positive, but what this code actually wants to do is use ERR_CAST() to
retain the error value.

Cc: Anton Altaparmakov <anton@tuxera.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/ntfs/namei.c