net: stmmac: fix handling of zero coalescing tx-usecs
authorVincent Whitchurch <vincent.whitchurch@axis.com>
Thu, 7 Sep 2023 10:46:31 +0000 (12:46 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 11 Sep 2023 07:22:47 +0000 (08:22 +0100)
commitfa60b8163816f194786f3ee334c9a458da7699c6
tree1c7d850b007f44ae0b03055d7df0802e8b490c09
parent6eadb0b3d085ccbed224599d131425611506c018
net: stmmac: fix handling of zero coalescing tx-usecs

Setting ethtool -C eth0 tx-usecs 0 is supposed to disable the use of the
coalescing timer but currently it gets programmed with zero delay
instead.

Disable the use of the coalescing timer if tx-usecs is zero by
preventing it from being restarted.  Note that to keep things simple we
don't start/stop the timer when the coalescing settings are changed, but
just let that happen on the next transmit or timer expiry.

Fixes: 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races")
Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c