i2c: qcom-cci: fix autosuspend cleanup
authorGuangshuo Li <lgs201920130244@gmail.com>
Wed, 12 Aug 2026 09:44:25 +0000 (17:44 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Fri, 28 Aug 2026 00:52:43 +0000 (02:52 +0200)
commitf98d4986482151a835b521a734722fe8dc5ca37d
treeb9eb6aa23050ce39ed16f6bbf05d8f7f5d2853c2
parent77549d01edecc20da73c8599e14648877198ce9b
i2c: qcom-cci: fix autosuspend cleanup

cci_probe() calls pm_runtime_use_autosuspend(), but the remove path
does not call the matching pm_runtime_dont_use_autosuspend() before
disabling runtime PM.

If the autosuspend delay is set to a negative value while autosuspend
is enabled, the runtime PM core increments usage_count to prevent
runtime suspend. Without undoing the autosuspend setting during
teardown, this reference is not dropped and usage_count remains
unbalanced.

Use devm_pm_runtime_set_active_enabled() to manage the runtime PM
state. Its managed cleanup disables autosuspend and runtime PM and
restores the suspended state on probe failure and driver removal.
Remove the now redundant manual runtime PM cleanup.

This issue was found by manual code inspection.

Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Cc: <stable@vger.kernel.org> # v5.8+
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://patch.msgid.link/20260812094425.3515179-1-lgs201920130244@gmail.com
drivers/i2c/busses/i2c-qcom-cci.c