locking: Remove spin_lock_flags() etc
authorArnd Bergmann <arnd@arndb.de>
Fri, 22 Oct 2021 11:59:38 +0000 (13:59 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Sat, 30 Oct 2021 14:37:28 +0000 (16:37 +0200)
commitf98a3dccfcb0b9b9c3bef8df9edd61cda80ad937
treea4cd719ee2fe9681435bdf9150ca96d1d8b834a8
parent5197fcd09ab6dcc4df79edec7e8e27575276374c
locking: Remove spin_lock_flags() etc

parisc, ia64 and powerpc32 are the only remaining architectures that
provide custom arch_{spin,read,write}_lock_flags() functions, which are
meant to re-enable interrupts while waiting for a spinlock.

However, none of these can actually run into this codepath, because
it is only called on architectures without CONFIG_GENERIC_LOCKBREAK,
or when CONFIG_DEBUG_LOCK_ALLOC is set without CONFIG_LOCKDEP, and none
of those combinations are possible on the three architectures.

Going back in the git history, it appears that arch/mn10300 may have
been able to run into this code path, but there is a good chance that
it never worked. On the architectures that still exist, it was
already impossible to hit back in 2008 after the introduction of
CONFIG_GENERIC_LOCKBREAK, and possibly earlier.

As this is all dead code, just remove it and the helper functions built
around it. For arch/ia64, the inline asm could be cleaned up, but
it seems safer to leave it untouched.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Helge Deller <deller@gmx.de> # parisc
Link: https://lore.kernel.org/r/20211022120058.1031690-1-arnd@kernel.org
12 files changed:
arch/ia64/include/asm/spinlock.h
arch/openrisc/include/asm/spinlock.h
arch/parisc/include/asm/spinlock.h
arch/powerpc/include/asm/simple_spinlock.h
arch/s390/include/asm/spinlock.h
include/linux/lockdep.h
include/linux/rwlock.h
include/linux/rwlock_api_smp.h
include/linux/spinlock.h
include/linux/spinlock_api_smp.h
include/linux/spinlock_up.h
kernel/locking/spinlock.c