rsi: Properly initialize data in rsi_sdio_ta_reset
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 23 May 2019 15:30:08 +0000 (08:30 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 28 May 2019 11:31:36 +0000 (14:31 +0300)
commitf57b5d85ed5865f0cd0a6dc4726c995b9e57e28a
treeee630720ca9d63b14a4ee6d495bc54bdf830c54f
parenta24bad74737f4c8814e0669d38dba5f2ddb86514
rsi: Properly initialize data in rsi_sdio_ta_reset

When building with -Wuninitialized, Clang warns:

drivers/net/wireless/rsi/rsi_91x_sdio.c:940:43: warning: variable 'data'
is uninitialized when used here [-Wuninitialized]
        put_unaligned_le32(TA_HOLD_THREAD_VALUE, data);
                                                 ^~~~
drivers/net/wireless/rsi/rsi_91x_sdio.c:930:10: note: initialize the
variable 'data' to silence this warning
        u8 *data;
                ^
                 = NULL
1 warning generated.

Using Clang's suggestion of initializing data to NULL wouldn't work out
because data will be dereferenced by put_unaligned_le32. Use kzalloc to
properly initialize data, which matches a couple of other places in this
driver.

Fixes: e5a1ecc97e5f ("rsi: add firmware loading for 9116 device")
Link: https://github.com/ClangBuiltLinux/linux/issues/464
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/rsi/rsi_91x_sdio.c