net: pcs: xpcs: Return EINVAL in the internal methods
authorSerge Semin <fancer.lancer@gmail.com>
Thu, 22 Feb 2024 17:58:22 +0000 (20:58 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Feb 2024 13:09:08 +0000 (13:09 +0000)
commitf5151005d379d9ce42e327fd3b2d2aaef61cda81
tree172e0cccd448948bd610e14a07bbbc3b87afa038
parente26802ebd29573cdca9bcc01c8731db9ffc3332b
net: pcs: xpcs: Return EINVAL in the internal methods

In particular the xpcs_soft_reset() and xpcs_do_config() functions
currently return -1 if invalid auto-negotiation mode is specified. That
value might be then passed to the generic kernel subsystems which require
a standard kernel errno value. Even though the erroneous conditions are
very specific (memory corruption or buggy driver implementation) using a
hard-coded -1 literal doesn't seem correct anyway especially when it comes
to passing it higher to the network subsystem or printing to the system
log.  Convert the hard-coded error values to -EINVAL then.

Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/pcs/pcs-xpcs.c