PCI: Fix pci_enable_acs() support for the ACS quirks
authorJason Gunthorpe <jgg@nvidia.com>
Wed, 16 Oct 2024 23:52:33 +0000 (20:52 -0300)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 29 Oct 2024 16:35:52 +0000 (11:35 -0500)
commitf3c3ccc4fe49dbc560b01d16bebd1b116c46c2b4
tree0920180237bd30470f84239d6cfaac9293f8f865
parent9852d85ec9d492ebef56dc5f229416c925758edc
PCI: Fix pci_enable_acs() support for the ACS quirks

There are ACS quirks that hijack the normal ACS processing and deliver to
to special quirk code. The enable path needs to call
pci_dev_specific_enable_acs() and then pci_dev_specific_acs_enabled() will
report the hidden ACS state controlled by the quirk.

The recent rework got this out of order and we should try to call
pci_dev_specific_enable_acs() regardless of any actual ACS support in the
device.

As before command line parameters that effect standard PCI ACS don't
interact with the quirk versions, including the new config_acs= option.

Link: https://lore.kernel.org/r/0-v1-f96b686c625b+124-pci_acs_quirk_fix_jgg@nvidia.com
Fixes: 47c8846a49ba ("PCI: Extend ACS configurability")
Reported-by: Jiri Slaby <jirislaby@kernel.org>
Closes: https://lore.kernel.org/all/e89107da-ac99-4d3a-9527-a4df9986e120@kernel.org
Closes: https://bugzilla.suse.com/show_bug.cgi?id=1229019
Tested-by: Steffen Dirkwinkel <me@steffen.cc>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/pci.c