brcmfmac: p2p: Replace one-element arrays with flexible-array members
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 4 Feb 2022 23:22:28 +0000 (17:22 -0600)
committerKalle Valo <kvalo@kernel.org>
Thu, 10 Feb 2022 08:46:20 +0000 (10:46 +0200)
commitf3c04fffe2717878d032a275f16d1e397402da10
tree28ccc62339c9a9a3490ac0173c101b703cead510
parent28e7ea8a3128a5626dee12a63ca8e8f8e6786608
brcmfmac: p2p: Replace one-element arrays with flexible-array members

There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].

This helps with the ongoing efforts to globally enable -Warray-bounds
and get us closer to being able to tighten the FORTIFY_SOURCE routines
on memcpy().

This issue was found with the help of Coccinelle and audited and fixed,
manually.

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays

Link: https://github.com/KSPP/linux/issues/79
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220204232228.GA442895@embeddedor
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c