pwm: tegra: Improve required rate calculation
authorJon Hunter <jonathanh@nvidia.com>
Fri, 28 Oct 2022 12:33:55 +0000 (13:33 +0100)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 9 Nov 2022 17:30:52 +0000 (18:30 +0100)
commitf271946117dde2ca8741b8138b347b2d68e6ad56
treed0c3269fc8dfc57ff93f8531e6767720721ada8e
parent9abf2313adc1ca1b6180c508c25f22f9395cc780
pwm: tegra: Improve required rate calculation

For the case where dev_pm_opp_set_rate() is called to set the PWM clock
rate, the requested rate is calculated as ...

 required_clk_rate = (NSEC_PER_SEC / period_ns) << PWM_DUTY_WIDTH;

The above calculation may lead to rounding errors because the
NSEC_PER_SEC is divided by 'period_ns' before applying the
PWM_DUTY_WIDTH multiplication factor. For example, if the period is
45334ns, the above calculation yields a rate of 5646848Hz instead of
5646976Hz. Fix this by applying the multiplication factor before
dividing and using the DIV_ROUND_UP macro which yields the expected
result of 5646976Hz.

Fixes: 1d7796bdb63a ("pwm: tegra: Support dynamic clock frequency configuration")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-tegra.c