RDMA/core: Require the driver to set the IOVA correctly during rereg_mr
authorAharon Landau <aharonl@nvidia.com>
Thu, 28 Oct 2021 05:55:22 +0000 (08:55 +0300)
committerJason Gunthorpe <jgg@nvidia.com>
Wed, 3 Nov 2021 12:37:52 +0000 (09:37 -0300)
commitf1a090f09f42be5a5542009f0be310fdb3e768fc
tree93dc83cc33bb6a57465b7fe60b694bde62c9b353
parentdd83f482d2cd5aa6a515a343b822c12b66661c2e
RDMA/core: Require the driver to set the IOVA correctly during rereg_mr

If the driver returns a new MR during rereg it has to fill it with the
IOVA from the proper source. If IB_MR_REREG_TRANS is set then the IOVA is
cmd.hca_va, otherwise the IOVA comes from the old MR. mlx5 for example has
two calls inside rereg_mr:

return create_real_mr(new_pd, umem, mr->ibmr.iova,
      new_access_flags);
and
return create_real_mr(new_pd, new_umem, iova, new_access_flags);

Unconditionally overwriting the iova in the newly allocated MR will
corrupt the iova if the first path is used.

Remove the redundant initializations from ib_uverbs_rereg_mr().

Fixes: 6e0954b11c05 ("RDMA/uverbs: Allow drivers to create a new HW object during rereg_mr")
Link: https://lore.kernel.org/r/4b0a31bbc372842613286a10d7a8cbb0ee6069c7.1635400472.git.leonro@nvidia.com
Signed-off-by: Aharon Landau <aharonl@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/core/uverbs_cmd.c