rtc: ds1672: fix unintended sign extension
authorColin Ian King <colin.king@canonical.com>
Tue, 5 Feb 2019 18:04:49 +0000 (18:04 +0000)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 5 Feb 2019 22:11:31 +0000 (23:11 +0100)
commitf0c04c276739ed8acbb41b4868e942a55b128dca
treeeba81c2db274e9c836ff65d7d81e45283c786c26
parent75455e258ea2b3ea08f08edc41735a447c3e7711
rtc: ds1672: fix unintended sign extension

Shifting a u8 by 24 will cause the value to be promoted to an integer. If
the top bit of the u8 is set then the following conversion to an unsigned
long will sign extend the value causing the upper 32 bits to be set in
the result.

Fix this by casting the u8 value to an unsigned long before the shift.

Detected by CoverityScan, CID#138801 ("Unintended sign extension")

Fixes: edf1aaa31fc5 ("[PATCH] RTC subsystem: DS1672 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ds1672.c