drivers: thermal: tsens: fix potential integer overflow on multiply
authorColin Ian King <colin.king@canonical.com>
Fri, 1 Nov 2019 10:00:35 +0000 (10:00 +0000)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 7 Nov 2019 06:00:26 +0000 (07:00 +0100)
commitf0a353b4d184b36a68e3d6951b5027a0c6c0c526
treee4efe2adf551d8b7adb8f451c0e9b5dbb24d7e74
parent0cac7559f1b67aa29879ead6b6b6a856d963905f
drivers: thermal: tsens: fix potential integer overflow on multiply

Currently a multiply operation is being performed on two int values
and the result is being assigned to a u64, presumably because the
end result is expected to be probably larger than an int. However,
because the multiply is an int multiply one can get overflow. Avoid
the overflow by casting degc to a u64 to force a u64 multiply.

Also use div_u64 for the divide as suggested by Daniel Lezcano.

Addresses-Coverity: ("Unintentional integer overflow")
Fixes: fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Link: https://lore.kernel.org/r/20191101100035.25502-1-colin.king@canonical.com
drivers/thermal/qcom/tsens-common.c