media: uvcvideo: Avoid invalid memory access
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 1 Dec 2021 05:22:17 +0000 (06:22 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 7 Dec 2021 10:29:54 +0000 (11:29 +0100)
commitf0577b1b6394f954903fcc67e12fe9e7001dafd6
tree2413d6bb9540184cbb4ebb43ac3c2372e4720434
parentc8ed7d2f614cd8b315981d116c7a2fb01829500d
media: uvcvideo: Avoid invalid memory access

If mappings points to an invalid memory, we will be invalid accessing
it. Solve it by initializing the value of the variable mapping and by
changing the order in the conditional statement (to avoid accessing
mapping->id if not needed).

Fix:
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN NOPTI

Fixes: 6350d6a4ed487 ("media: uvcvideo: Set error_idx during ctrl_commit errors")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/uvc/uvc_ctrl.c