watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already running
authorMika Westerberg <mika.westerberg@linux.intel.com>
Fri, 28 Oct 2022 06:27:50 +0000 (09:27 +0300)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 19 Nov 2022 14:30:41 +0000 (15:30 +0100)
commitef9b7bf52c2f47f0a9bf988543c577b92c92d15e
tree6988f086c4c34d569f55af8920bffa8ba007daf9
parent47c008050aec3e9a13af29dd74cd8b4c112bc07b
watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already running

Daniel reported that the commit 1ae3e78c0820 ("watchdog: iTCO_wdt: No
need to stop the timer in probe") makes QEMU implementation of the iTCO
watchdog not to trigger reboot anymore when NO_REBOOT flag is initially
cleared using this option (in QEMU command line):

  -global ICH9-LPC.noreboot=false

The problem with the commit is that it left the unconditional setting of
NO_REBOOT that is not cleared anymore when the kernel keeps pinging the
watchdog (as opposed to the previous code that called iTCO_wdt_stop()
that cleared it).

Fix this so that we only set NO_REBOOT if the watchdog was not initially
running.

Fixes: 1ae3e78c0820 ("watchdog: iTCO_wdt: No need to stop the timer in probe")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20221028062750.45451-1-mika.westerberg@linux.intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/iTCO_wdt.c