KVM: selftests: Fix 32-bit truncation of vm_get_max_gfn()
authorDavid Matlack <dmatlack@google.com>
Fri, 21 May 2021 17:38:28 +0000 (17:38 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 27 May 2021 11:45:54 +0000 (07:45 -0400)
commitef4c9f4f654622fa15b7a94a9bd1f19e76bb7feb
tree696ca6602c9a16c7b3f536f604831eb738b1a364
parentcad347fab142bcb9bebc125b5ba0c1e52ce74fdc
KVM: selftests: Fix 32-bit truncation of vm_get_max_gfn()

vm_get_max_gfn() casts vm->max_gfn from a uint64_t to an unsigned int,
which causes the upper 32-bits of the max_gfn to get truncated.

Nobody noticed until now likely because vm_get_max_gfn() is only used
as a mechanism to create a memslot in an unused region of the guest
physical address space (the top), and the top of the 32-bit physical
address space was always good enough.

This fix reveals a bug in memslot_modification_stress_test which was
trying to create a dummy memslot past the end of guest physical memory.
Fix that by moving the dummy memslot lower.

Fixes: 52200d0d944e ("KVM: selftests: Remove duplicate guest mode handling")
Reviewed-by: Venkatesh Srinivas <venkateshs@chromium.org>
Signed-off-by: David Matlack <dmatlack@google.com>
Message-Id: <20210521173828.1180619-1-dmatlack@google.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
tools/testing/selftests/kvm/include/kvm_util.h
tools/testing/selftests/kvm/lib/kvm_util.c
tools/testing/selftests/kvm/lib/perf_test_util.c
tools/testing/selftests/kvm/memslot_modification_stress_test.c