net: bmac: Fix read of MAC address from ROM
authorJeremy Kerr <jk@ozlabs.org>
Tue, 19 May 2020 01:05:58 +0000 (09:05 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 May 2020 19:03:37 +0000 (12:03 -0700)
commitef01cee2ee1b369c57a936166483d40942bcc3e3
tree1353e6ff7c37c9191a6d0d8bf6cab56e77e0a9f2
parentb15e62631c5f19fea9895f7632dae9c1b27fe0cd
net: bmac: Fix read of MAC address from ROM

In bmac_get_station_address, We're reading two bytes at a time from ROM,
but we do that six times, resulting in 12 bytes of read & writes. This
means we will write off the end of the six-byte destination buffer.

This change fixes the for-loop to only read/write six bytes.

Based on a proposed fix from Finn Thain <fthain@telegraphics.com.au>.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Reported-by: Stan Johnson <userm57@yahoo.com>
Tested-by: Stan Johnson <userm57@yahoo.com>
Reported-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/apple/bmac.c