HID: make arrays usage and value to be the same
authorWill McVicker <willmcvicker@google.com>
Sat, 5 Dec 2020 00:48:48 +0000 (00:48 +0000)
committerJiri Kosina <jkosina@suse.cz>
Mon, 18 Jan 2021 08:09:57 +0000 (09:09 +0100)
commited9be64eefe26d7d8b0b5b9fa3ffdf425d87a01f
tree69719f3d0c6436c8d4a21e506872dede9374f5be
parenta0312af1f94d13800e63a7d0a66e563582e39aec
HID: make arrays usage and value to be the same

The HID subsystem allows an "HID report field" to have a different
number of "values" and "usages" when it is allocated. When a field
struct is created, the size of the usage array is guaranteed to be at
least as large as the values array, but it may be larger. This leads to
a potential out-of-bounds write in
__hidinput_change_resolution_multipliers() and an out-of-bounds read in
hidinput_count_leds().

To fix this, let's make sure that both the usage and value arrays are
the same size.

Cc: stable@vger.kernel.org
Signed-off-by: Will McVicker <willmcvicker@google.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-core.c