net, neigh: Set lower cap for neigh_managed_work rearming
authorDaniel Borkmann <daniel@iogearbox.net>
Tue, 24 May 2022 22:56:18 +0000 (00:56 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 26 May 2022 05:00:48 +0000 (22:00 -0700)
commited6cd6a17896561b9f51ab4c0d9bbb29e762b597
tree48d0d7fa93663bc51c4295279a2ccfd34dd14768
parentb3b1a17538d3ef6a9667b2271216fd16d7678ab5
net, neigh: Set lower cap for neigh_managed_work rearming

Yuwei reported that plain reuse of DELAY_PROBE_TIME to rearm work queue
in neigh_managed_work is problematic if user explicitly configures the
DELAY_PROBE_TIME to 0 for a neighbor table. Such misconfig can then hog
CPU to 100% processing the system work queue. Instead, set lower interval
bound to HZ which is totally sufficient. Yuwei is additionally looking
into making the interval separately configurable from DELAY_PROBE_TIME.

Reported-by: Yuwei Wang <wangyuweihx@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/netdev/797c3c53-ce1b-9f60-e253-cda615788f4a@iogearbox.net
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://lore.kernel.org/r/3b8c5aa906c52c3a8c995d1b2e8ccf650ea7c716.1653432794.git.daniel@iogearbox.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/neighbour.c