leds: simatic-ipc-leds-gpio: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sat, 16 Sep 2023 16:45:16 +0000 (18:45 +0200)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:33 +0000 (11:28 +0000)
commiteccc489ef68d70cfdd850ba24933f1febbf2893e
treed0d2e51bdbc4257f4e02fbdac0637b8a2b667a53
parent0847c33bafe5b58f2f223153c007c1e185f84f48
leds: simatic-ipc-leds-gpio: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Make simatic_ipc_leds_gpio_remove() return void instead of returning
zero unconditionally. After that the three remove callbacks that use
this function were trivial to convert to return void, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230916164516.1063380-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c
drivers/leds/simple/simatic-ipc-leds-gpio-core.c
drivers/leds/simple/simatic-ipc-leds-gpio-elkhartlake.c
drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c
drivers/leds/simple/simatic-ipc-leds-gpio.h