9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition
authorZheng Wang <zyytlz.wz@163.com>
Mon, 13 Mar 2023 14:43:25 +0000 (22:43 +0800)
committerEric Van Hensbergen <ericvh@kernel.org>
Sun, 2 Apr 2023 01:00:31 +0000 (01:00 +0000)
commitea4f1009408efb4989a0f139b70fb338e7f687d0
treef586f7d47b325285d7e643ffe577e3944efe6e46
parent707823e7f22f3864ddc7d85e8e9b614afe4f1b16
9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition

In xen_9pfs_front_probe, it calls xen_9pfs_front_alloc_dataring
to init priv->rings and bound &ring->work with p9_xen_response.

When it calls xen_9pfs_front_event_handler to handle IRQ requests,
it will finally call schedule_work to start the work.

When we call xen_9pfs_front_remove to remove the driver, there
may be a sequence as follows:

Fix it by finishing the work before cleanup in xen_9pfs_front_free.

Note that, this bug is found by static analysis, which might be
false positive.

CPU0                  CPU1

                     |p9_xen_response
xen_9pfs_front_remove|
  xen_9pfs_front_free|
kfree(priv)          |
//free priv          |
                     |p9_tag_lookup
                     |//use priv->client

Fixes: 71ebd71921e4 ("xen/9pfs: connect to the backend")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
net/9p/trans_xen.c