nvme: fix identify error status silent ignore
authorSagi Grimberg <sagi@grimberg.me>
Fri, 26 Jun 2020 17:46:29 +0000 (10:46 -0700)
committerChristoph Hellwig <hch@lst.de>
Thu, 2 Jul 2020 08:38:00 +0000 (10:38 +0200)
commitea43d9709f727e728e933a8157a7a7ca1a868281
tree30d71119a2dfbeafcb6a5f7dfae1400be5bd3894
parente7eea44eefbdd5f0345a0a8b80a3ca1c21030d06
nvme: fix identify error status silent ignore

Commit 59c7c3caaaf8 intended to only silently ignore non retry-able
errors (DNR bit set) such that we can still identify misbehaving
controllers, and in the other hand propagate retry-able errors (DNR bit
cleared) so we don't wrongly abandon a namespace just because it happens
to be temporarily inaccessible.

The goal remains the same as the original commit where this was
introduced but unfortunately had the logic backwards.

Fixes: 59c7c3caaaf8 ("nvme: fix possible hang when ns scanning fails during error recovery")
Reported-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c