mtd: revert "spi-nor: intel: provide a range for poll_timout"
authorLuis Alberto Herrera <luisalberto@google.com>
Wed, 10 Jun 2020 22:46:49 +0000 (22:46 +0000)
committerTudor Ambarus <tudor.ambarus@microchip.com>
Tue, 28 Jul 2020 08:35:27 +0000 (11:35 +0300)
commite93a977367b2aefff3c1fb426bbdfc6e2980815f
tree0e2b395f59bfaad758435b52552cfb87a83fb70e
parent99eae48fd4c5c59a76de17bc036a2dbd7f698bfd
mtd: revert "spi-nor: intel: provide a range for poll_timout"

This change reverts aba3a882a178: "mtd: spi-nor: intel: provide a range
for poll_timout". That change introduces a performance regression when
reading sequentially from flash. Logging calls to intel_spi_read without
this change we get:

Start MTD read
[   20.045527] intel_spi_read(from=1800000, len=400000)
[   20.045527] intel_spi_read(from=1800000, len=400000)
[  282.199274] intel_spi_read(from=1c00000, len=400000)
[  282.199274] intel_spi_read(from=1c00000, len=400000)
[  544.351528] intel_spi_read(from=2000000, len=400000)
[  544.351528] intel_spi_read(from=2000000, len=400000)
End MTD read

With this change:

Start MTD read
[   21.942922] intel_spi_read(from=1c00000, len=400000)
[   21.942922] intel_spi_read(from=1c00000, len=400000)
[   23.784058] intel_spi_read(from=2000000, len=400000)
[   23.784058] intel_spi_read(from=2000000, len=400000)
[   25.625006] intel_spi_read(from=2400000, len=400000)
[   25.625006] intel_spi_read(from=2400000, len=400000)
End MTD read

Signed-off-by: Luis Alberto Herrera <luisalberto@google.com>
Tested-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20200610224652.64336-1-luisalberto@google.com
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
drivers/mtd/spi-nor/controllers/intel-spi.c