libbpf: Don't error out on CO-RE relos for overriden weak subprogs
authorAndrii Nakryiko <andrii@kernel.org>
Fri, 8 Apr 2022 18:14:23 +0000 (11:14 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 8 Apr 2022 20:24:15 +0000 (22:24 +0200)
commite89d57d938c8fa80c457982154ed6110804814fe
treea5a6b8b62931835354fc3ad34e1348a35895e5e5
parent587323cf6a6a6da074f0518444ee7da10f517f45
libbpf: Don't error out on CO-RE relos for overriden weak subprogs

During BPF static linking, all the ELF relocations and .BTF.ext
information (including CO-RE relocations) are preserved for __weak
subprograms that were logically overriden by either previous weak
subprogram instance or by corresponding "strong" (non-weak) subprogram.
This is just how native user-space linkers work, nothing new.

But libbpf is over-zealous when processing CO-RE relocation to error out
when CO-RE relocation belonging to such eliminated weak subprogram is
encountered. Instead of erroring out on this expected situation, log
debug-level message and skip the relocation.

Fixes: db2b8b06423c ("libbpf: Support CO-RE relocations for multi-prog sections")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20220408181425.2287230-2-andrii@kernel.org
tools/lib/bpf/libbpf.c