media: pci: cx23885: Fix the error handling in cx23885_initdev()
authorZheyu Ma <zheyuma97@gmail.com>
Sun, 10 Apr 2022 07:34:41 +0000 (08:34 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 24 Apr 2022 07:50:12 +0000 (08:50 +0100)
commite8123311cf06d7dae71e8c5fe78e0510d20cd30b
treec1fac8ec3a371981fb6d9fb9181f835df47614f0
parentf83bd49cbc373983ba79bf4cd55fb6bff7901d36
media: pci: cx23885: Fix the error handling in cx23885_initdev()

When the driver fails to call the dma_set_mask(), the driver will get
the following splat:

[   55.853884] BUG: KASAN: use-after-free in __process_removed_driver+0x3c/0x240
[   55.854486] Read of size 8 at addr ffff88810de60408 by task modprobe/590
[   55.856822] Call Trace:
[   55.860327]  __process_removed_driver+0x3c/0x240
[   55.861347]  bus_for_each_dev+0x102/0x160
[   55.861681]  i2c_del_driver+0x2f/0x50

This is because the driver has initialized the i2c related resources
in cx23885_dev_setup() but not released them in error handling, fix this
bug by modifying the error path that jumps after failing to call the
dma_set_mask().

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/pci/cx23885/cx23885-core.c