LSM: fix return value check in safesetid_init_securityfs()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 12 Feb 2019 07:58:31 +0000 (07:58 +0000)
committerJames Morris <james.morris@microsoft.com>
Tue, 12 Feb 2019 18:59:22 +0000 (10:59 -0800)
commite7a44cfd639945a0dec749f896adc1d340c2a6aa
treef89795ae1dc53a5d41afe349291fb1176ea58473
parentc67e8ec03f3fd41c0b75f5596eee92460f4957c0
LSM: fix return value check in safesetid_init_securityfs()

In case of error, the function securityfs_create_dir() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: aeca4e2ca65c ("LSM: add SafeSetID module that gates setid calls")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: James Morris <james.morris@microsoft.com>
security/safesetid/securityfs.c