drm/i915: fix size_t greater or equal to zero comparison
authorColin Ian King <colin.king@canonical.com>
Fri, 2 Oct 2020 17:03:54 +0000 (18:03 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 7 Dec 2020 10:44:17 +0000 (10:44 +0000)
commite70956a2498dc81d8f2522cba074f55ae910e13c
treea7f4fc45e0fe46882384fd046c01606f0ebcbadd
parent6ca07255ac409fd78931b3def62896e7e6541a47
drm/i915: fix size_t greater or equal to zero comparison

Currently the check that the unsigned size_t variable i is >= 0
is always true because the unsigned variable will never be negative,
causing the loop to run forever.  Fix this by changing the
pre-decrement check to a zero check on i followed by a decrement of i.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: bfed6708d6c9 ("drm/i915: use vmap in shmem_pin_map")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20201002170354.94627-1-colin.king@canonical.com
drivers/gpu/drm/i915/gt/shmem_utils.c