drm: Don't race connector registration
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 12 Jan 2017 16:15:56 +0000 (17:15 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 30 Jan 2017 09:17:32 +0000 (10:17 +0100)
commite6e7b48b295afa5a5ab440de0a94d9ad8b3ce2d0
tree77cadb6d8aad1b52c34e4afa8c9deef603bbe2ed
parent4e5b54f127426c82dc2816340c26d951a5bb3429
drm: Don't race connector registration

I was under the misconception that the sysfs dev stuff can be fully
set up, and then registered all in one step with device_add. That's
true for properties and property groups, but not for parents and child
devices. Those must be fully registered before you can register a
child.

Add a bit of tracking to make sure that asynchronous mst connector
hotplugging gets this right. For consistency we rely upon the implicit
barriers of the connector->mutex, which is taken anyway, to ensure
that at least either the connector or device registration call will
work out.

Mildly tested since I can't reliably reproduce this on my mst box
here.

Reported-by: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1484237756-2720-1-git-send-email-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_connector.c
drivers/gpu/drm/drm_drv.c
include/drm/drmP.h