net: stmmac: explicitly deassert GMAC_AHB_RESET
authorMatthew Hagan <mnhagan88@gmail.com>
Tue, 8 Jun 2021 18:59:06 +0000 (19:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jun 2021 23:42:12 +0000 (16:42 -0700)
commite67f325e9cd67562b761e884680c0fec03a6f404
treec416b275167245fa72edd139b24307af935933b1
parent52481e585951f4a199678cd6e61f85db52548a01
net: stmmac: explicitly deassert GMAC_AHB_RESET

We are currently assuming that GMAC_AHB_RESET will already be deasserted
by the bootloader. However if this has not been done, probing of the GMAC
will fail. To remedy this we must ensure GMAC_AHB_RESET has been deasserted
prior to probing.

v2 changes:
 - remove NULL condition check for stmmac_ahb_rst in stmmac_main.c
 - unwrap dev_err() message in stmmac_main.c
 - add PTR_ERR() around plat->stmmac_ahb_rst in stmmac_platform.c

v3 changes:
 - add error pointer to dev_err() output
 - add reset_control_assert(stmmac_ahb_rst) in stmmac_dvr_remove
 - revert PTR_ERR() around plat->stmmac_ahb_rst since this is performed
   on the returned value of ret by the calling function

Signed-off-by: Matthew Hagan <mnhagan88@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
include/linux/stmmac.h