sched/uclamp: Fix a deadlock when enabling uclamp static key
authorQais Yousef <qais.yousef@arm.com>
Thu, 16 Jul 2020 11:03:47 +0000 (12:03 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 29 Jul 2020 11:51:47 +0000 (13:51 +0200)
commite65855a52b479f98674998cb23b21ef5a8144b04
treeea641813091126bbc0d7ef4ec02b938cbe8488d8
parent21a6ee14a8f277766618ef07154432b46528113e
sched/uclamp: Fix a deadlock when enabling uclamp static key

The following splat was caught when setting uclamp value of a task:

  BUG: sleeping function called from invalid context at ./include/linux/percpu-rwsem.h:49

   cpus_read_lock+0x68/0x130
   static_key_enable+0x1c/0x38
   __sched_setscheduler+0x900/0xad8

Fix by ensuring we enable the key outside of the critical section in
__sched_setscheduler()

Fixes: 46609ce22703 ("sched/uclamp: Protect uclamp fast path code with static key")
Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200716110347.19553-4-qais.yousef@arm.com
kernel/sched/core.c