selftests/mptcp: Better delay & reordering configuration
authorChristoph Paasch <cpaasch@apple.com>
Thu, 10 Sep 2020 05:07:36 +0000 (22:07 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Sep 2020 20:28:20 +0000 (13:28 -0700)
commite54846581891b8cf1c8c903a4feae65a5aa27ed5
tree877023a0d4d052d16c307c5445f617ed272b3366
parentd095c46206be74a96dac2daf21506ab06c3ddfb1
selftests/mptcp: Better delay & reordering configuration

The delay was intended to be configured to "simulate" a high(er) BDP
link. As such, it needs to be set as part of the loss-configuration and
not as part of the netem reordering configuration.

The reordering-config also requires a delay but that delay is the
reordering-extend. So, a good approach is to set the reordering-extend
as a function of the configured latency. E.g., 25% of the overall
latency.

To speed up the selftests, we limit the delay to 50ms maximum to avoid
having the selftests run for too long.

Finally, the intention of tc_reorder was that when it is unset, the test
picks a random configuration. However, currently it is always initialized
and thus the random config won't be picked up.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/6
Reported-and-reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/mptcp/mptcp_connect.sh