Merge branch 'cleanup the legacy probe_event on failed scenario'
authorAndrii Nakryiko <andrii@kernel.org>
Wed, 6 Jul 2022 04:20:42 +0000 (21:20 -0700)
committerAndrii Nakryiko <andrii@kernel.org>
Wed, 6 Jul 2022 04:23:07 +0000 (21:23 -0700)
commite4adceef5b0e75f000754254047af59c65295ac4
tree777cb0284845c78e21a0d861a5b1eab6e54f73c2
parentf6b9f6d57e5c765b5ff358af1d7749df5e30334c
parent2655144fb49bae26eae038c6d056f824a7db2726
Merge branch 'cleanup the legacy probe_event on failed scenario'

Chuang Wang says:

====================
A potential scenario, when an error is returned after
add_uprobe_event_legacy() in perf_event_uprobe_open_legacy(), or
bpf_program__attach_perf_event_opts() in
bpf_program__attach_uprobe_opts() returns an error, the uprobe_event
that was previously created is not cleaned.

At the same time, the legacy kprobe_event also have similar problems.

With these patches, whenever an error is returned, it ensures that
the created kprobe_event/uprobe_event is cleaned.

V1 -> v3:

- add detail commits
- call remove_kprobe_event_legacy() on failed bpf_program__attach_perf_event_opts()

v3 -> v4:

- cleanup the legacy kprobe_event on failed add/attach_event
====================

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>