net, neigh: Fix NTF_EXT_LEARNED in combination with NTF_USE
authorDaniel Borkmann <daniel@iogearbox.net>
Mon, 11 Oct 2021 12:12:35 +0000 (14:12 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Oct 2021 10:27:47 +0000 (11:27 +0100)
commite4400bbf5b15750e1b59bf4722d18d99be60c69f
tree48e380c5f2b58ac2eb0cd75667c17def9cca802c
parent7bb39a394490c0690dc7304f2f0345539d590d2b
net, neigh: Fix NTF_EXT_LEARNED in combination with NTF_USE

The NTF_EXT_LEARNED neigh flag is usually propagated back to user space
upon dump of the neighbor table. However, when used in combination with
NTF_USE flag this is not the case despite exempting the entry from the
garbage collector. This results in inconsistent state since entries are
typically marked in neigh->flags with NTF_EXT_LEARNED, but here they are
not. Fix it by propagating the creation flag to ___neigh_create().

Before fix:

  # ./ip/ip n replace 192.168.178.30 dev enp5s0 use extern_learn
  # ./ip/ip n
  192.168.178.30 dev enp5s0 lladdr f4:8c:50:5e:71:9a REACHABLE
  [...]

After fix:

  # ./ip/ip n replace 192.168.178.30 dev enp5s0 use extern_learn
  # ./ip/ip n
  192.168.178.30 dev enp5s0 lladdr f4:8c:50:5e:71:9a extern_learn REACHABLE
  [...]

Fixes: 9ce33e46531d ("neighbour: support for NTF_EXT_LEARNED flag")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Roopa Prabhu <roopa@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/neighbour.c