net: ethernet: aeroflex: fix UAF in greth_of_remove
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 18 Jun 2021 14:57:31 +0000 (17:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 19 Jun 2021 18:45:10 +0000 (11:45 -0700)
commite3a5de6d81d8b2199935c7eb3f7d17a50a7075b7
tree9e2d776ac1c45651fab21d1e238ca17320c1e142
parent9ed13a17e38e0537e24d9b507645002bf8d0201f
net: ethernet: aeroflex: fix UAF in greth_of_remove

static int greth_of_remove(struct platform_device *of_dev)
{
...
struct greth_private *greth = netdev_priv(ndev);
...
unregister_netdev(ndev);
free_netdev(ndev);

of_iounmap(&of_dev->resource[0], greth->regs, resource_size(&of_dev->resource[0]));
...
}

greth is netdev private data, but it is used
after free_netdev(). It can cause use-after-free when accessing greth
pointer. So, fix it by moving free_netdev() after of_iounmap()
call.

Fixes: d4c41139df6e ("net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aeroflex/greth.c